Fix UMF build on Alpine OS #1294
Open
+105
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lplewa
reviewed
May 5, 2025
Comment on lines
+157
to
+163
| #if (_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600) && !_GNU_SOURCE | ||
| char err[1024]; | ||
| int err_ret = strerror_r(saveno, err, sizeof(err)); | ||
| if (err_ret == ERANGE) { | ||
| postfix = "[truncated...]"; | ||
| } | ||
| #else |
There was a problem hiding this comment.
is it different from the apple version? can you just update apple ifdef?
| run: | | ||
| docker build . -f .github/docker/alpine-3.20.Dockerfile -t alpine_image | ||
|
|
||
| - name: Run UMF build on Alpine image |
There was a problem hiding this comment.
we could also run tests on the build (not sure if as part of build.sh or as a separate step here)
There was a problem hiding this comment.
Setting up the necessary dependencies on Alpine is not worth the effort (at least for the purpose of fixing this issue)
wlemkows
force-pushed
the
alpine-umf
branch
6 times, most recently
from
2000a75 to
28f0fe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist